KAFKA-19096: Added checks for the number of dropped records to innerJoinShouldPropagateNothingWhenOldAndNewFKIsNull and innerJoinShouldNotPropagateDeletionOfPrimaryKeyWhenPreviousFKIsNull tests. #21111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oinShouldPropagateNothingWhenOldAndNewFKIsNull and innerJoinShouldNotPropagateDeletionOfPrimaryKeyWhenPreviousFKIsNull tests.
github-actions
bot
added
triage
| assertThat(context.forwarded(), empty()); | ||
|
|
||
| // test dropped-records sensors | ||
| assertEquals(1.0, getDroppedRecordsTotalMetric(context)); |
Contributor
Author
There was a problem hiding this comment.
according to the comment: https://github.com/mjsax/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java#L177
it's an invalid situation, so we report it as a dropped record.
Please correct me if I am wrong with my conclusion
mjsax
reviewed
Dec 9, 2025
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Test update LGTM. Just wondering if we would need to extend all tests in this class (or maybe also other related tests)?
No idea if test coverage is dense or sparse right now for all the different cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fix: #20605