KAFKA-20002: Reset-by-duration should not hand back task to state-updater #21167
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ater This bug was introduced via KAFKA-18015.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where active tasks undergoing reset-by-duration were incorrectly being handed back to the state updater. The state updater is responsible for restoring task state, not managing active tasks during offset reset operations. The incorrect behavior was introduced in KAFKA-18015.
Key Changes:
- Removed erroneous
stateUpdater.add(task)call frommaybeInitTaskTimeoutsOrThrowmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pankraz76
approved these changes
Dec 17, 2025
Comment on lines
1850
to
1851
| final Task task = getActiveTask(partition); | ||
| task.maybeInitTaskTimeoutOrThrow(nowMs, timeoutException); |
There was a problem hiding this comment.
Suggested change
| final Task task = getActiveTask(partition); | |
| task.maybeInitTaskTimeoutOrThrow(nowMs, timeoutException); | |
| getActiveTask(partition).maybeInitTaskTimeoutOrThrow(nowMs, timeoutException); |
coupling now seems obsolete, considering cohesion.
Pankraz76
reviewed
Dec 18, 2025
| ) { | ||
| for (final TopicPartition partition : partitions) { | ||
| final Task task = getActiveTask(partition); | ||
| task.maybeInitTaskTimeoutOrThrow(nowMs, timeoutException); |
There was a problem hiding this comment.
ty for boiling down.
Now we have reached final version, can not take away anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced via KAFKA-18015.
Reviewers: Lucas Brutschy lbrutschy@confluent.io