KAFKA-8958 : Fix Kafka Streams JavaDocs with regard to used Serdes #21237
+178
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a specific Serde is used earlier in the code, it will reuse that one instead of looking at the global defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we have updated the Kafka Streams JavaDocs regarding the use of Serdes for specified classes.
In the older javadocs, the documentation incorrectly stated that many operations used the 'default serializer' from the configuration.
We have updated this to clarify that Serdes are often preserved from the upstream operator, and only fall back to defaults when necessary.
Ticket link :- https://issues.apache.org/jira/browse/KAFKA-8958