KAFKA-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs #21277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o enable setting admin configs
# Conflicts: # docs/configuration.html
github-actions
bot
added
triage
DL1231
changed the title
chia7712
reviewed
Jan 11, 2026
...pache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java
Outdated
Show resolved
Hide resolved
chia7712
approved these changes
Jan 12, 2026
chia7712
reviewed
Jan 12, 2026
|
|
||
| private Map<String, Object> createAdminProps(Map<String, Object> allAdminConfigs) { | ||
| Map<String, Object> props = new HashMap<>(allAdminConfigs); | ||
| props.put(ProducerConfig.CLIENT_ID_CONFIG, clientIdPrefix + "_admin"); |
Member
There was a problem hiding this comment.
ProducerConfig -> AdminClientConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
TopicBasedRemoteLogMetadataManagercreates the Admin clientusing
commonProperties(), which prevents users from settingadmin-specific configurations (e.g., custom timeouts, retry policies).
This commit adds a new configuration prefix
remote.log.metadata.admin.*to allow separate configuration for theAdmin client, similar to the existing producer and consumer prefixes.
Reviewers: TengYao Chi frankvicky@apache.org, Chia-Ping Tsai
chia7712@gmail.com