KAFKA-19233: Add tests for duplicate heartbeat request handling #21319
Conversation
This adds tests to validate that duplicate full heartbeat requests are handled idempotently in all member states (STABLE, UNREVOKED_PARTITIONS, UNRELEASED_PARTITIONS). Each test verifies that the duplicate produces the same response with no records generated.
github-actions
bot
added
core
|
|
||
| assertEquals(MemberState.STABLE, context.consumerGroupMemberState(groupId, memberId)); | ||
|
|
||
| // Duplicate heartbeat with same request but epoch is now stale. |
There was a problem hiding this comment.
nit: The comment is a bit misleading. Would it be better to say Duplicate heartbeat with same request but with the new epoch.
There was a problem hiding this comment.
agree is confusing, but actually if the intention is to testDuplicateFullHeartbeatWithRevocationAck I guess the comment is right but the epoch 101 is wrong (should be 100).
Shouldn't we just remove the duplicateRequest and send the same fullRequest from above?
|
|
||
| assertEquals(MemberState.STABLE, context.consumerGroupMemberState(groupId, memberId)); | ||
|
|
||
| // Duplicate heartbeat with same request but epoch is now stale. |
There was a problem hiding this comment.
agree is confusing, but actually if the intention is to testDuplicateFullHeartbeatWithRevocationAck I guess the comment is right but the epoch 101 is wrong (should be 100).
Shouldn't we just remove the duplicateRequest and send the same fullRequest from above?
mjsax
changed the title
3 participants
This patch adds tests to validate that duplicate full heartbeat requests
are handled idempotently in all member states (STABLE,
UNREVOKED_PARTITIONS, UNRELEASED_PARTITIONS).
Reviewers: Dongnuo Lyu dlyu@confluent.io, Lianet Magrans
lmagrans@confluent.io