KAFKA-20064: Made PartitionLeaderCache thread safe. #21335
Merged
+310
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Nikita-Shupletsov Test failures for |
Member
|
And is this PR superseding #21298? |
Contributor
Author
fixed
this PR is from @seekskyworld. He and I sent our PRs in parallel |
AndrewJSchofield
requested changes
Jan 22, 2026
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. Some comments from an initial review.
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public InetAddress[] resolve(String host) throws UnknownHostException { | ||
| System.out.println("RESOLVE: " + host); |
Member
There was a problem hiding this comment.
Please remove the println.
| adminClient = KafkaAdminClient.createInternal(new AdminClientConfig(clusterInstance.setClientSaslConfig(props), true), | ||
| null, new TestHostResolver()); | ||
|
|
||
| Field clientField = KafkaAdminClient.class.getDeclaredField("client"); |
Member
There was a problem hiding this comment.
I would prefer TestUtils.fieldValue here.
Replaced direct reflection with TestUtils.
AndrewJSchofield
approved these changes
Jan 29, 2026
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good to me.
Nikita-Shupletsov
added a commit
to Nikita-Shupletsov/kafka
that referenced
this pull request
Jan 30, 2026
* Introduced a new class - PartitionLeaderCache * Changed the usage of the cache to make calls atomic(e.g. getting cached and non-cached values as one call instead of two, deleting cached values as one call, not one by one) * Added an integration test that tests the concurrent access of the cache Reviewers: Andrew Schofield <aschofield@confluent.io>
Nikita-Shupletsov
added a commit
to Nikita-Shupletsov/kafka
that referenced
this pull request
Jan 30, 2026
* Introduced a new class - PartitionLeaderCache * Changed the usage of the cache to make calls atomic(e.g. getting cached and non-cached values as one call instead of two, deleting cached values as one call, not one by one) * Added an integration test that tests the concurrent access of the cache Reviewers: Andrew Schofield <aschofield@confluent.io>
chia7712
pushed a commit
that referenced
this pull request
Jan 30, 2026
Backport of #21335 * Introduced a new class - PartitionLeaderCache * Changed the usage of the cache to make calls atomic(e.g. getting cached and non-cached values as one call instead of two, deleting cached values as one call, not one by one) * Added an integration test that tests the concurrent access of the cache Reviewers: Andrew Schofield <aschofield@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
Member
|
@clolov Can we target this patch for the 4.2.0 release? |
chia7712
pushed a commit
that referenced
this pull request
Jan 30, 2026
* Introduced a new class - PartitionLeaderCache * Changed the usage of the cache to make calls atomic(e.g. getting cached and non-cached values as one call instead of two, deleting cached values as one call, not one by one) * Added an integration test that tests the concurrent access of the cache Reviewers: Andrew Schofield <aschofield@confluent.io>
Member
|
chatted with @clolov offline, and he agrees to cherry-pick to 4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cached and non-cached values as one call instead of two, deleting cached
values as one call, not one by one)
cache
Reviewers: Andrew Schofield aschofield@confluent.io