MINOR: Correct exception naming and preserve original headers in DLQ#21378
Merged
chia7712 merged 2 commits intoapache:4.2from Jan 31, 2026
Merged
MINOR: Correct exception naming and preserve original headers in DLQ#21378chia7712 merged 2 commits intoapache:4.2from
chia7712 merged 2 commits intoapache:4.2from
Conversation
…pache#21370) This patch fixed two mismatch between [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) and the actual implementation: - Incorrect value of `HEADER_ERRORS_EXCEPTION_NAME`, it should be the name of the thrown exception, not exception's String representation. - Original headers from record that causes exception should be added to dlq record headers. References: - apache#17942 (comment) - apache#17942 (comment) - [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) Reviewers: Lucas Brutschy <lbrutschy@confluent.io>
chia7712
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #21370, with an additional checkstyle fix
(adding a
finalkeyword to make checkstyle works in 4.2 branch).This patch fixed two mismatch between
KIP-1034
and the actual implementation:
HEADER_ERRORS_EXCEPTION_NAME, it should be thename of the thrown exception, not exception's String representation.
dlq record headers.
References:
KIP-1034
Reviewers: Lucas Brutschy lbrutschy@confluent.io, Chia-Ping Tsai
chia7712@gmail.com