KAFKA-20173: Propagate headers into serde 1/N#21490
Conversation
1fb66a2 to
f32fe8f
Compare
|
@mjsax Hello. |
streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowedDeserializerTest.java
Show resolved
Hide resolved
…WindowedDeserializerTest.java
|
Is the PR description correct?
Does this PR really cover the entire package? |
|
Build failed with checkstyle error: |
Thanks for checking. I found two more calls to serializer in this package (previously I checked only deserializer). They are from the same classes, so I'll add them |
not sure about the scope of the change. Should we consider the deserializer in Oh, OK, you said |
frankvicky
left a comment
There was a problem hiding this comment.
Overall LGTM
Please run ./gradlew spotlessApply to fix the CI.
5c22a7b to
3d340ff
Compare
|
@mjsax @aliehsaeedii |
|
@UladzislauBlok Thanks for the PR, merged. |
Propagate headers into serializes / deserializers
This PR partially covers
org.apache.kafka.streams.kstreampackage.Code:
Tests:
Reviewers: Matthias J. Sax matthias@confluent.io, Alieh Saeedi
asaeedi@confluent.io, TengYao Chi frankvicky@apache.org