KAFKA-20201: Connect Transforms: SchemaUtil.copySchemaBasics(Schema) does not preserve keySchema and valueSchema for MAP type#21525
Open
CokeLee777 wants to merge 1 commit intoapache:trunkfrom
Open
Conversation
CokeLee777
force-pushed
the
KAFKA-20201
branch
from
97ea107 to
b69f233
Compare
Fixes a latent bug in `SchemaUtil.copySchemaBasics(Schema)` where passing a MAP schema would result in a broken `SchemaBuilder` with null `keySchema` and `valueSchema`. Added a MAP type branch to correctly copy the key and value schemas, and included corresponding unit tests.
CokeLee777
force-pushed
the
KAFKA-20201
branch
from
b69f233 to
11786f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a latent bug in
SchemaUtil.copySchemaBasics(Schema)where passing a MAP schema would result in a brokenSchemaBuilderwith nullkeySchemaandvalueSchema.Added a MAP type branch to correctly copy the key and value schemas, and included corresponding unit tests.
Note:
Currently, no callers within the codebase pass a MAP schema to this method, so there are no active runtime failures. However, since SchemaUtil#copySchemaBasics is a public utility method, this is a latent bug. This proactive fix ensures that if any future transforms or external connectors pass a MAP schema, it will be handled correctly.