Skip to content

Comments

MINOR Use pull_request instead of pull_request_target#21530

Merged
mumrah merged 1 commit intotrunkfrom
minor-pull-request-labeler
Feb 21, 2026
Merged

MINOR Use pull_request instead of pull_request_target#21530
mumrah merged 1 commit intotrunkfrom
minor-pull-request-labeler

Conversation

@mumrah
Copy link
Member

@mumrah mumrah commented Feb 21, 2026

ASF has requested that we remove usages of pull_request_target. This
patch changes the labeler to use pull_request.

Reviewers: Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Feb 21, 2026
@mumrah mumrah requested a review from chia7712 February 21, 2026 00:27
@mumrah
Copy link
Member Author

mumrah commented Feb 21, 2026

This PR will break the "triage" label functionality and might completely remove the ability for contributor PRs to get labeled automatically. Since it's not really possible to test this, we just have to merge this and try it.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check it out

@mumrah mumrah merged commit e567025 into trunk Feb 21, 2026
17 checks passed
@mumrah
Copy link
Member Author

mumrah commented Feb 21, 2026

@chia7712 yea, it doesn't work :(

Even a PR opened by a committer will fail https://github.com/apache/kafka/actions/runs/22247346330/job/64364042394?pr=21531 since it's in the "mumrah" org and not "apache". "mumrah" does not have access to the necessary Github token to update the PR.

If I open a PR in "apache" org (which only committers can do), then it will work. However, this does not match our normal workflows with committers using public forks.

I'm going to revert this one and we'll have to think of another approach.

mumrah added a commit that referenced this pull request Feb 21, 2026
mumrah added a commit that referenced this pull request Feb 21, 2026
…" (#21532)

This reverts commit e567025.

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions small Small PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants