MINOR Use pull_request instead of pull_request_target#21530
Merged
Conversation
Member
Author
|
This PR will break the "triage" label functionality and might completely remove the ability for contributor PRs to get labeled automatically. Since it's not really possible to test this, we just have to merge this and try it. |
Member
Author
|
@chia7712 yea, it doesn't work :( Even a PR opened by a committer will fail https://github.com/apache/kafka/actions/runs/22247346330/job/64364042394?pr=21531 since it's in the "mumrah" org and not "apache". "mumrah" does not have access to the necessary Github token to update the PR. If I open a PR in "apache" org (which only committers can do), then it will work. However, this does not match our normal workflows with committers using public forks. I'm going to revert this one and we'll have to think of another approach. |
mumrah
added a commit
that referenced
this pull request
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASF has requested that we remove usages of pull_request_target. This
patch changes the labeler to use pull_request.
Reviewers: Chia-Ping Tsai chia7712@gmail.com