MINOR: Improve CRC failure handling share groups#21569
Merged
AndrewJSchofield merged 4 commits intoapache:trunkfrom Mar 2, 2026
Merged
MINOR: Improve CRC failure handling share groups#21569AndrewJSchofield merged 4 commits intoapache:trunkfrom
AndrewJSchofield merged 4 commits intoapache:trunkfrom
Conversation
apoorvmittal10
approved these changes
Feb 26, 2026
Contributor
apoorvmittal10
left a comment
apoorvmittal10
left a comment
There was a problem hiding this comment.
LGTM, seems the right fix.
nicktelford
pushed a commit
to nicktelford/kafka
that referenced
this pull request
Mar 6, 2026
The handling of CRC failures in CompletedShareFetch was incorrect, particularly when multiple CRC failures occurred. This PR adds a bunch of tests and corrects the logic for keeping track of the position when a batch is rejected. Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handling of CRC failures in CompletedShareFetch was incorrect,
particularly when multiple CRC failures occurred. This PR adds a bunch
of tests and corrects the logic for keeping track of the position when a
batch is rejected.
Reviewers: Apoorv Mittal apoorvmittal10@gmail.com