KAFKA-19562: Replace hand-written AbortedTxn with generated protocol#21577
Open
mingyen066 wants to merge 6 commits intoapache:trunkfrom
Open
KAFKA-19562: Replace hand-written AbortedTxn with generated protocol#21577mingyen066 wants to merge 6 commits intoapache:trunkfrom
mingyen066 wants to merge 6 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
mingyen066
force-pushed
the
KAFKA-19562-rewrite-aborted-txn-by-generated-protocol
branch
from
4d49f23 to
078353e
Compare
Replace the manually maintained AbortedTxn class with a generated protocol message defined in AbortedTxn.json. The generated class provides the same wire format (2-byte version prefix + 4 int64 fields) ensuring binary compatibility with existing transaction index files.
mingyen066
force-pushed
the
KAFKA-19562-rewrite-aborted-txn-by-generated-protocol
branch
from
078353e to
25a1108
Compare
chia7712
reviewed
Mar 3, 2026
storage/src/main/java/org/apache/kafka/storage/internals/log/AbortedTxn.java
Show resolved
Hide resolved
chia7712
reviewed
Mar 3, 2026
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Mar 6, 2026
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java
Outdated
Show resolved
Hide resolved
Move buffer and position allocation inside the iterator() lambda so each call to iterator() gets its own independent state, properly satisfying the Iterable contract. Add a test to verify this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manually maintained AbortedTxn class with a generated
protocol message defined in AbortedTxn.json.
Also simplifies TransactionIndex buffer management since the generated
class copies field values at construction time instead of holding a
buffer reference.