KAFKA-20258 Refactor DSL store config and propagate dslStoreFormat#21784
Merged
mjsax merged 3 commits intoapache:trunkfrom Mar 18, 2026
Merged
KAFKA-20258 Refactor DSL store config and propagate dslStoreFormat#21784mjsax merged 3 commits intoapache:trunkfrom
mjsax merged 3 commits intoapache:trunkfrom
Conversation
aliehsaeedii
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Thanks, @zheguang! I left a comment in the ticket. All changes except those in the DslKeyValueParams class will be handled differently as described in https://issues.apache.org/jira/browse/KAFKA-20279. To keep things aligned with that approach, could you please revert your other changes and keep only the updates to DslKeyValueParams? Once that’s done, we can go ahead and merge the PR. Sorry for the back and forth!
The config will be handled differently by https://issues.apache.org/jira/browse/KAFKA-20279 This reverts commit 27f009d.
Contributor
Author
|
Done! Thanks for the pointer :) |
mjsax
approved these changes
Mar 18, 2026
Member
|
Thanks for the PR @zheguang! Merged to |
Shekharrajak
pushed a commit
to Shekharrajak/kafka
that referenced
this pull request
Mar 31, 2026
…pache#21784) This patch removes dead code `isTimeStamped`. Reviewers: Alieh Saeedi <asaeedi@confluent.io>, Matthias J. Sax <matthias@confluent.io>
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
…pache#21784) This patch removes dead code `isTimeStamped`. Reviewers: Alieh Saeedi <asaeedi@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes dead code
isTimeStamped.Reviewers: Alieh Saeedi asaeedi@confluent.io, Matthias J. Sax
matthias@confluent.io