KAFKA-20326: WindowStoreMaterializerTests needs to get updated#21825
Merged
Conversation
| } | ||
| if (stateStore instanceof TimestampedToHeadersWindowStoreAdapter) { | ||
| return isTimeOrderedStore(((TimestampedToHeadersWindowStoreAdapter) stateStore).store); | ||
| } |
Contributor
There was a problem hiding this comment.
Should it simply return true as the TimestampedToXxx indicate it?
Member
There was a problem hiding this comment.
I don't think so -- we only that what we wrapped a WindowStore<Bytes, byte[]> -- but could be any type. It's not guaranteed that it's a RocksDBTimeOrderedWindowStore.
mjsax
pushed a commit
that referenced
this pull request
Mar 20, 2026
`shouldCreateHeadersStoreWithOnWindowCloseAndCachingEnabled` is incorrect – we removed a check to make it pass for now, but need to add back the correct assertion after the root cause was fixed. ref: https://github.com/apache/kafka/pull/21580/changes#r2921529513 Reviewers: Alieh Saeedi <asaeedi@confluent.io>, Matthias J. Sax <matthias@confluent.io>
Member
|
Merged to |
Shekharrajak
pushed a commit
to Shekharrajak/kafka
that referenced
this pull request
Mar 31, 2026
…e#21825) `shouldCreateHeadersStoreWithOnWindowCloseAndCachingEnabled` is incorrect – we removed a check to make it pass for now, but need to add back the correct assertion after the root cause was fixed. ref: https://github.com/apache/kafka/pull/21580/changes#r2921529513 Reviewers: Alieh Saeedi <asaeedi@confluent.io>, Matthias J. Sax <matthias@confluent.io>
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
…e#21825) `shouldCreateHeadersStoreWithOnWindowCloseAndCachingEnabled` is incorrect – we removed a check to make it pass for now, but need to add back the correct assertion after the root cause was fixed. ref: https://github.com/apache/kafka/pull/21580/changes#r2921529513 Reviewers: Alieh Saeedi <asaeedi@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldCreateHeadersStoreWithOnWindowCloseAndCachingEnabledisincorrect – we removed a check to make it pass for now, but need to add
back the correct assertion after the root cause was fixed.
ref: https://github.com/apache/kafka/pull/21580/changes#r2921529513
Reviewers: Alieh Saeedi asaeedi@confluent.io, Matthias J. Sax
matthias@confluent.io