Skip to content

MINOR: Fix default server config in BenchmarkConfigUtils#21839

Merged
chia7712 merged 1 commit intoapache:trunkfrom
mimaison:fix-benchmark-config
Mar 21, 2026
Merged

MINOR: Fix default server config in BenchmarkConfigUtils#21839
chia7712 merged 1 commit intoapache:trunkfrom
mimaison:fix-benchmark-config

Conversation

@mimaison
Copy link
Member

@mimaison mimaison commented Mar 20, 2026

Since
ed367cf
when running benchmarks that call createDummyBrokerConfig() we get the
following error:

java.lang.IllegalArgumentException: requirement failed: If process.roles
contains just the 'broker' role, the node id 0 must not be included in
the set of voters controller.quorum.voters=Set(0)

Reviewers: Chia-Ping Tsai chia7712@gmail.com

@chia7712
Copy link
Member

IIRC, I ran all the changed benchmarks to ensure every thing worked... but I definitely did something stupid here. My bad!

#21310 (comment)

@mimaison
Copy link
Member Author

No worries! Since it's the only commit that touched BenchmarkConfigUtils I assumed it was the cause but maybe it's not. I did not do a full bisect as it does not really matter.

@chia7712
Copy link
Member

Okay, I made sure to actually run ReplicaFetcherThreadBenchmark, CheckpointBench, and PartitionCreationBench this time! Everything looks good. LGTM

@chia7712 chia7712 merged commit 9e8bb29 into apache:trunk Mar 21, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants