KAFKA-13499: Avoid restoring outdated records#21901
Merged
bbejeck merged 8 commits intoapache:trunkfrom Mar 31, 2026
Merged
Conversation
…ctRocksDBSegmentedBytesStore.java revert
…oreChangelogReaderTest.java
bbejeck
reviewed
Mar 30, 2026
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
@gabriellefu the AbstractDualSchemaRocksDBSegmentBytesStore needs to implement the WithRetentionPeriod interface
Member
|
@gabriellefu same issue with |
Member
|
Merged #21901 into trunk |
bbejeck
pushed a commit
that referenced
this pull request
Mar 31, 2026
1. Expose the retentionPeriod length to storeMetadata 2. In prepareChangelogs(), switch it from always seektobeginning if checkpoint doesn't exist to seek to certain timestamp to avoid restoring outdated records. Reviewers: TengYao Chi <frankvicky@apache.org> , Bill Bejeck <bbejeck@apache.org>
Member
|
cherry-picked to 4.3 |
Member
|
It seems this PR did introduce some bug. Reverted it from It seems to be related to |
Member
|
Also reverted in |
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
1. Expose the retentionPeriod length to storeMetadata 2. In prepareChangelogs(), switch it from always seektobeginning if checkpoint doesn't exist to seek to certain timestamp to avoid restoring outdated records. Reviewers: TengYao Chi <frankvicky@apache.org> , Bill Bejeck <bbejeck@apache.org>
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
This reverts commit f55073b.
bbejeck
pushed a commit
that referenced
this pull request
May 4, 2026
1. Expose the retentionPeriod length to storeMetadata 2. In prepareChangelogs(), switch it from always seektobeginning if checkpoint doesn't exist to seek to certain timestamp to avoid restoring outdated records. 3. Change from [the ](#21901): Instead of the wall clock, use the latest timestamp in the changelog as the latest time, and seek from the timestamp of latest_changelog_stamp_time-rention_period. Reviewers: TengYao Chi <frankvicky@apache.org>, Bill Bejeck <bbejeck@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkpoint doesn't exist to seek to certain timestamp to avoid restoring
outdated records.
Reviewers: TengYao Chi frankvicky@apache.org , Bill Bejeck
bbejeck@apache.org