KAFKA-20336: Add documentation DSL headers-aware state stores#21905
Open
Shekharrajak wants to merge 5 commits intoapache:trunkfrom
Open
KAFKA-20336: Add documentation DSL headers-aware state stores#21905Shekharrajak wants to merge 5 commits intoapache:trunkfrom
Shekharrajak wants to merge 5 commits intoapache:trunkfrom
Conversation
5a2303c to
30e87ca
Compare
mimaison
reviewed
Apr 2, 2026
Author
|
@mimaison It is looking good to merge now. |
Member
|
Well we need someone with Streams knowledge to review the changes. I just commented on the form. |
Member
|
@mjsax / @aliehsaeedii are probably the ones closer to this KIP? |
Contributor
aliehsaeedii
left a comment
There was a problem hiding this comment.
Thanks @Shekharrajak fior the PR.
I made a pass and left some comments. Beside those, the PR doesn't document:
- Performance implications - larger changelogs, more I/O (Check PR #21840 please.)
- Migration process - what happens when you change from "default" to "headers"
- Maybe changelog format changes and restore implications
Contributor
|
@Shekharrajak are you still working on this PR? |
Author
|
@aliehsaeedii , I am looking into this. |
51a21b4 to
3dcc86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-20336: Add documentation for KIP-1285 DSL headers-aware state
stores
Ref https://issues.apache.org/jira/browse/KAFKA-20336
docs/streams/developer-guide/config-streams.md