KAFKA-20339: Remove assignment offloading configs for 4.3#21926
KAFKA-20339: Remove assignment offloading configs for 4.3#21926dajac merged 4 commits intoapache:4.3from
Conversation
|
Just realized the 4.3 branch isn't triggering CI. Filling a PR to fix this now. FYI @mimaison |
|
|
@squah-confluent Could you please rebase to include #21937? |
The KIP-1263 assignment offloading configs aren't fully supported yet in Apache Kafka 4.3. Mark them as internal to hide them from users.
61a2c3e to
c311673
Compare
|
It seems we are mixing the server configs with the original configs, which results in the internal configs being exposed. We can fix this behavior in the trunk branch. To avoid blocking the 4.3 release, maybe we could just delete that code instead? |
|
I missed this case. @dajac raised the group internal config concern when I implemented the group synonym support #21855 (comment), but I didn't consider that an internal group config could also have a broker synonym. The |
|
@majialoong and I discussed this offline, and I agree to handle these internal configs in a separate PR. However, if we prefer to stick with internal configs for the 4.3 branch for now, fixing it in this PR is absolutely fine. @majialoong has already pinpointed the critical path." |
|
@chia7712 I've opted to remove the config definitions instead. |
|
@squah-confluent Thanks. Could you please check the build? |
|
@majialoong Let's fix it upstream, as suggested. Thanks! |
|
we could remove the check from BTW, @majialoong I have opened KAFKA-20409 for you |
The KIP-1263 assignment offloading configs aren't fully supported yet
in Apache Kafka 4.3. Remove them to hide them from users.
Reviewers: David Jacot djacot@confluent.io, majialong majialoong@gmail.com, Chia-Ping Tsai chia7712@gmail.com