Skip to content

KAFKA-20339: Remove assignment offloading configs for 4.3#21926

Merged
dajac merged 4 commits intoapache:4.3from
confluentinc:squah-kip-1263-internal-offloading-configs
Apr 7, 2026
Merged

KAFKA-20339: Remove assignment offloading configs for 4.3#21926
dajac merged 4 commits intoapache:4.3from
confluentinc:squah-kip-1263-internal-offloading-configs

Conversation

@squah-confluent
Copy link
Copy Markdown
Contributor

@squah-confluent squah-confluent commented Apr 1, 2026

The KIP-1263 assignment offloading configs aren't fully supported yet
in Apache Kafka 4.3. Remove them to hide them from users.

Reviewers: David Jacot djacot@confluent.io, majialong majialoong@gmail.com, Chia-Ping Tsai chia7712@gmail.com

Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the page still states the target version is 4.3.0. Should we update it as well?

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Apr 2, 2026

Just realized the 4.3 branch isn't triggering CI. Filling a PR to fix this now. FYI @mimaison

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Apr 2, 2026

Just realized the 4.3 branch isn't triggering CI. Filling a PR to fix this now.

#21937

Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dajac
Copy link
Copy Markdown
Member

dajac commented Apr 2, 2026

@squah-confluent Could you please rebase to include #21937?

The KIP-1263 assignment offloading configs aren't fully supported yet
in Apache Kafka 4.3. Mark them as internal to hide them from users.
@airlock-confluentinc airlock-confluentinc bot force-pushed the squah-kip-1263-internal-offloading-configs branch from 61a2c3e to c311673 Compare April 2, 2026 14:43
@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Apr 3, 2026

It seems we are mixing the server configs with the original configs, which results in the internal configs being exposed.

We can fix this behavior in the trunk branch. To avoid blocking the 4.3 release, maybe we could just delete that code instead?

@majialoong
Copy link
Copy Markdown
Contributor

I missed this case. @dajac raised the group internal config concern when I implemented the group synonym support #21855 (comment), but I didn't consider that an internal group config could also have a broker synonym. The createResponseConfig alone can't filter it out in this case. If needed, I can send a follow-up PR to fix this on trunk.

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Apr 3, 2026

@majialoong and I discussed this offline, and I agree to handle these internal configs in a separate PR.

However, if we prefer to stick with internal configs for the 4.3 branch for now, fixing it in this PR is absolutely fine.

@majialoong has already pinpointed the critical path."

@squah-confluent squah-confluent changed the title KAFKA-20339: Mark assignment offloading configs internal for 4.3 KAFKA-20339: Hide assignment offloading configs for 4.3 Apr 6, 2026
@squah-confluent squah-confluent changed the title KAFKA-20339: Hide assignment offloading configs for 4.3 KAFKA-20339: Remove assignment offloading configs for 4.3 Apr 6, 2026
@squah-confluent
Copy link
Copy Markdown
Contributor Author

@chia7712 I've opted to remove the config definitions instead.

@dajac
Copy link
Copy Markdown
Member

dajac commented Apr 7, 2026

@squah-confluent Thanks. Could you please check the build?

@dajac
Copy link
Copy Markdown
Member

dajac commented Apr 7, 2026

@majialoong Let's fix it upstream, as suggested. Thanks!

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Apr 7, 2026

we could remove the check from testDynamicGroupCoordinatorConfig to fix it.

BTW, @majialoong I have opened KAFKA-20409 for you

Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dajac dajac merged commit fd7b5ec into apache:4.3 Apr 7, 2026
18 checks passed
@dajac dajac deleted the squah-kip-1263-internal-offloading-configs branch April 7, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants