KAFKA-15853: [2/N] Move bulk of remaining configs to AbstractKafkaConfig#21943
Open
clolov wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-15853: [2/N] Move bulk of remaining configs to AbstractKafkaConfig#21943clolov wants to merge 1 commit intoapache:trunkfrom
clolov wants to merge 1 commit intoapache:trunkfrom
Conversation
nileshkumar3
reviewed
Apr 3, 2026
| public class AbstractConfig { | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(AbstractConfig.class); | ||
| public static final Logger log = LoggerFactory.getLogger(AbstractConfig.class); |
Contributor
There was a problem hiding this comment.
consider protected instead of public, or a dedicated logger in AbstractKafkaConfig, to avoid expanding AbstractConfig’s public surface.
Contributor
Author
There was a problem hiding this comment.
Fair suggestion, we only need this up until we get rid of the configurations which trigger the warnings, but I will swap it to protected
| // ********* Group Coordinator Configuration ********** | ||
|
|
||
| @SuppressWarnings("removal") | ||
| public Set<GroupType> groupCoordinatorRebalanceProtocols() { |
Contributor
There was a problem hiding this comment.
Moving groupCoordinatorRebalanceProtocols from a Scala val to a Java method re-runs validation/log.warn on every access—consider caching to match one-time init behavior.
Contributor
Author
There was a problem hiding this comment.
Also a fair suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the bulk of remaining KafkaConfig configs from Scala to
Java.