KAFKA-20194: Fix StoreBuilderWrapper for header-stores#21950
Merged
mjsax merged 6 commits intoapache:trunkfrom Apr 7, 2026
Merged
KAFKA-20194: Fix StoreBuilderWrapper for header-stores#21950mjsax merged 6 commits intoapache:trunkfrom
mjsax merged 6 commits intoapache:trunkfrom
Conversation
mjsax
commented
Apr 3, 2026
| return ((TimestampedWindowStoreWithHeadersBuilder<?, ?>) builder).retentionPeriod(); | ||
| } else if (builder instanceof SessionStoreBuilder) { | ||
| return ((SessionStoreBuilder<?, ?>) builder).retentionPeriod(); | ||
| } else if (builder instanceof SessionStoreBuilderWithHeaders) { |
Member
Author
There was a problem hiding this comment.
It seems we should rename this to SessionStoreWithHeadersBuilder` ?
StoreBuilderWrapper must recongnize header-stores correctly. Otherwise, we create changelog topics with incorrect topi configuration.
mjsax
force-pushed
the
minor-kip-1285-fix-storebuilderwrapper
branch
from
d30e3e3 to
9b3c0f3
Compare
mjsax
changed the title
mjsax
added a commit
that referenced
this pull request
Apr 7, 2026
StoreBuilderWrapper must recognize header-stores correctly. Otherwise, we create changelog topics with incorrect topic configuration. Also adding a fix to public API. The newly added methods to create a ts-ks-headers-store and session-headesr-store builder (on `Stores`) are incorrect (cf. KIP-1271). Also updated the corresponding internal class name for session-headers store. Reviewers: Bill Bejeck <bbejeck@apache.org>, Alieh Saeedi <asaeedi@confluent.io>
Member
Author
|
Merged to |
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
StoreBuilderWrapper must recognize header-stores correctly. Otherwise, we create changelog topics with incorrect topic configuration. Also adding a fix to public API. The newly added methods to create a ts-ks-headers-store and session-headesr-store builder (on `Stores`) are incorrect (cf. KIP-1271). Also updated the corresponding internal class name for session-headers store. Reviewers: Bill Bejeck <bbejeck@apache.org>, Alieh Saeedi <asaeedi@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StoreBuilderWrapper must recognize header-stores correctly. Otherwise,
we create changelog topics with incorrect topic configuration.
Also adding a fix to public API. The newly added methods to create a
ts-ks-headers-store and session-headesr-store builder (on
Stores) areincorrect (cf. KIP-1271).
Also updated the corresponding internal class name for session-headers
store.
Reviewers: Bill Bejeck bbejeck@apache.org, Alieh Saeedi
asaeedi@confluent.io