KAFKA-20337: Make all GroupConfig fields Optional and clean up validation#22003
Merged
chia7712 merged 1 commit intoapache:trunkfrom Apr 9, 2026
Merged
Conversation
github-actions
Bot
added
core
Member
Author
|
@squah-confluent I have been playing with those dynamic configs and I came up with this patch. Please take a look. |
Contributor
squah-confluent
left a comment
squah-confluent
left a comment
There was a problem hiding this comment.
Thanks for the refactor, looks good!
The approach to validate() where we only pass in the present parsed values is nice.
dajac
force-pushed
the
KAFKA-20337-optional-group-config
branch
from
96c26ce to
1e55293
Compare
chia7712
reviewed
Apr 9, 2026
| @@ -2828,7 +2828,8 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| } else { | |||
| // Compute group-specific timeout for caching errors (2 * heartbeat interval) | |||
| val heartbeatIntervalMs = Option(groupConfigManager.groupConfig(streamsGroupHeartbeatRequest.data.groupId).orElse(null)) | |||
Member
There was a problem hiding this comment.
val heartbeatIntervalMs = groupConfigManager.groupConfig(streamsGroupHeartbeatRequest.data.groupId)
.flatMap[java.lang.Integer](gc => gc.streamsHeartbeatIntervalMs())
.orElseGet(() => config.groupCoordinatorConfig.streamsGroupHeartbeatIntervalMs())
.toLong| @@ -324,48 +314,41 @@ public static Optional<String> brokerSynonym(String groupConfigName) { | |||
|
|
|||
| public GroupConfig(Map<?, ?> props) { | |||
| super(CONFIG_DEF, props, false); | |||
Member
There was a problem hiding this comment.
Have you considered dropping the AbstractConfig inheritance entirely? Since we now expect callers to strictly use the new Optional getter methods, extending AbstractConfig unnecessarily exposes a wider, unsafe API surface.
Member
Author
There was a problem hiding this comment.
Yes, I have. At the moment, AbstractConfig's methods are used by ConfigHelper so I stopped here in this PR. I will investigate this further as follow-ups.
…tion All GroupConfig fields are now Optional<T>, storing only explicitly provided values. Broker-level defaults are resolved at access time via flatMap().orElse(brokerDefault), eliminating stale-capture issues when broker configs change dynamically. Key changes: - All 21 GroupConfig fields are private Optional, using optionalInt/Boolean/String helpers based on originals(). - GroupConfigManager no longer needs a defaultConfig; constructor simplified. - GroupCoordinatorConfig.extractGroupConfigMap(ShareGroupConfig) removed. - All consumers (GroupMetadataManager, ShareGroupConfigProvider, KafkaApis) use flatMap. - validate() uses CONFIG_DEF.parse() directly instead of constructing a GroupConfig, keeping validation independent from GroupConfig construction. - validateValues refactored with validateIntRange/Max/Min helpers operating on a single filtered parsed map. - Cross-field checks use broker defaults for missing values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dajac
force-pushed
the
KAFKA-20337-optional-group-config
branch
from
1e55293 to
5f29cef
Compare
squah-confluent
approved these changes
Apr 9, 2026
chia7712
approved these changes
Apr 9, 2026
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
…ion (apache#22003) All GroupConfig fields are now Optional<T>, storing only explicitly provided values. Broker-level defaults are resolved at access time via flatMap().orElse(brokerDefault), eliminating stale-capture issues when broker configs change dynamically. Key changes: - All 21 GroupConfig fields are private Optional, using optionalInt/Boolean/String helpers based on originals(). - GroupConfigManager no longer needs a defaultConfig; constructor simplified. - GroupCoordinatorConfig.extractGroupConfigMap(ShareGroupConfig) removed. - All consumers (GroupMetadataManager, ShareGroupConfigProvider, KafkaApis) use flatMap. - validateValues refactored with validateIntRange/Max/Min helpers operating on a single filtered parsed map. - Cross-field checks use broker defaults for missing values. Reviewers: Sean Quah <squah@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All GroupConfig fields are now Optional, storing only explicitly
provided values. Broker-level defaults are resolved at access time via
flatMap().orElse(brokerDefault), eliminating stale-capture issues when
broker configs change dynamically.
Key changes:
optionalInt/Boolean/String helpers based on originals().
simplified.
removed.
KafkaApis) use flatMap.
operating on a single filtered parsed map.
Reviewers: Sean Quah squah@confluent.io, Chia-Ping Tsai
chia7712@gmail.com