KAFKA-20297 Move OperatingSystem, Java, Exit... into internal#22093
Merged
chia7712 merged 4 commits intoapache:trunkfrom Apr 21, 2026
Merged
KAFKA-20297 Move OperatingSystem, Java, Exit... into internal#22093chia7712 merged 4 commits intoapache:trunkfrom
chia7712 merged 4 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
cychiu8
reviewed
Apr 21, 2026
Contributor
cychiu8
left a comment
cychiu8
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have left a minor comment and everything else looks good.
| */ | ||
| package org.apache.kafka.common.utils; | ||
|
|
||
| import org.apache.kafka.common.utils.internals.Java; |
Contributor
There was a problem hiding this comment.
To keep the test suite organized, would it make sense to the tests (JavaTest, ExitTest, LoggingSingalHandlerTest, and ShellTest) into the utils/internals directory?
airlock-confluentinc Bot
pushed a commit
to confluentinc/schema-registry
that referenced
this pull request
Apr 27, 2026
…arness org.apache.kafka.common.utils.Java was moved into the internal package org.apache.kafka.common.utils.internals.Java by the same upstream KAFKA-20297 / apache/kafka#22093 / apache/kafka@0a367aa1 commit that moved Exit. Kafka 8.4.0-39-ccs ships only the internals copy, so the test compilation of ClusterTestHarness fails with cannot-find-symbol on Java. Java.isIbmJdk()/isIbmJdkSemeru() are two-line system-property checks (see ce-kafka:clients/.../utils/Java.java). Inline the equivalent expression so the test no longer depends on the now-internal class. This is the second of N forward-port fixes for the same KAFKA-20297 move; the previous commits handled Exit and the SpotBugs DM_EXIT suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have exposed several classes in org.apache.kafka.common.utils as
public APIs, which can be misleading since not all classes in this
package are intended for external use.
So move following class into internal module
Reviewers: cychiu cychiu8@gmail.com, Chia-Ping Tsai
chia7712@gmail.com