MINOR: Add DCL to improve performance#22098
Merged
chia7712 merged 2 commits intoapache:trunkfrom Apr 20, 2026
Merged
Conversation
github-actions
Bot
added
triage
mingyen066
approved these changes
Apr 20, 2026
Collaborator
mingyen066
left a comment
mingyen066
left a comment
There was a problem hiding this comment.
LGTM
nit: could you change title to MINOR instead of Minor
YutaLin
changed the title
mingyen066
reviewed
Apr 20, 2026
| * @return The sensor that is created | ||
| */ | ||
| public synchronized Sensor sensor(String name, MetricConfig config, Sensor... parents) { | ||
| public Sensor sensor(String name, MetricConfig config, Sensor... parents) { |
Collaborator
There was a problem hiding this comment.
Just for testing if I can trigger CI to auto fill reviewers
chia7712
reviewed
Apr 20, 2026
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
Overall LGTM. There were some flaky tests, so I'll re-run the CI to be sure
chia7712
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronized method will cause the process lock here every time, it
would be better to lock when we actually need to create the meter,
otherwise we can just return the existed value.
Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com