introduce private method to remove clones#22100
Open
aaaZayne wants to merge 1 commit intoapache:trunkfrom
Open
introduce private method to remove clones#22100aaaZayne wants to merge 1 commit intoapache:trunkfrom
aaaZayne wants to merge 1 commit intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
AndrewJSchofield
requested changes
Apr 28, 2026
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. Just one comment.
| }); | ||
| } else { | ||
| request.topics().forEach(topic -> { | ||
| String topicName = topic.name(); |
Member
There was a problem hiding this comment.
nit: There's no reason for this variable in the refactored code I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the same logic into a separate method addTopicIfAtOrAfterCursor to simplify logic