KAFKA-20362: Skip PR reviewer auto-fill when no usable email is available#22108
Open
mingyen066 wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20362: Skip PR reviewer auto-fill when no usable email is available#22108mingyen066 wants to merge 1 commit intoapache:trunkfrom
mingyen066 wants to merge 1 commit intoapache:trunkfrom
Conversation
…able Follow-up to apache#21928. For reviewers with "Keep my email addresses private" enabled, the author email surfaced by the commit history lookup is rewritten by GitHub to <id>+<login>@users.noreply.github.com on squash-merged commits, and their profile email is typically null. The script then wrote that noreply email, or a {login}@email-not-found placeholder when both tiers missed, into the Reviewers: trailer -- neither identifies the reviewer. Treat noreply and missing emails as "not found" and skip the trailer update entirely when no reliable email can be resolved. Reviewers whose real email is recoverable from the commit history or GitHub profile continue to be auto-filled as before.
github-actions
bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21928 (comment).
Skip the Reviewers auto-fill when no reliable email can be resolved,
rather than writing a noreply or placeholder email that has to be
corrected manually.