MINOR: Add toString() to KafkaMetric for readable logging#22129
Open
adikou wants to merge 1 commit intoapache:trunkfrom
Open
MINOR: Add toString() to KafkaMetric for readable logging#22129adikou wants to merge 1 commit intoapache:trunkfrom
adikou wants to merge 1 commit intoapache:trunkfrom
Conversation
This adds a toString() that includes the metric name, group, description, and tags. The metricValueProvider is represented by its simple class name rather than its full toString() to avoid dumping internal stat state like SampledStat's samples list into logs
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Author
|
Hi @AndrewJSchofield would you be able to take a look at this PR? I believe the tests have run to completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a toString() that includes the metric name, group, description, and tags. The metricValueProvider is represented by its simple class name rather than its full toString() to avoid dumping internal stat state like SampledStat's samples list into logs