KAFKA-20424 : clients: Update KafkaConsumerTest comments,tests with relevant protocol

[muralibasani]

Ref : https://issues.apache.org/jira/browse/KAFKA-20424

• 18 tests with updated comments (classic only)
• 1 test (testAutoCommitSentBeforePositionUpdate) now runs for both
  protocols.

Reviewers: Andrew Schofield aschofield@confluent.io

[muralibasani]

@lianetm can you pls take a look ?

[AndrewJSchofield]

This is a great start but I think this PR is only part of the work of https://issues.apache.org/jira/browse/KAFKA-20424 so I have not marked it as complete yet.

[AndrewJSchofield]

Thanks for the PR.

[muralibasani]

This is a great start but I think this PR is only part of the work of https://issues.apache.org/jira/browse/KAFKA-20424 so I have not marked it as complete yet.

@AndrewJSchofield thankyou for the review. For the other TODO comments, didn't want to mix it with this PR.
I had another ticket https://issues.apache.org/jira/browse/KAFKA-20527

[lianetm]

Hey @muralibasani , the testAutoCommitSentBeforePositionUpdate enabled here for the AsyncConsumer seems to be flaky on trunk, I filed https://issues.apache.org/jira/browse/KAFKA-20565.
If you have bandwidth to take a look into it please feel free to take it. If not I will just disable it for the Async Consumer while we get time to look into it.
Thanks!