KAFKA-20528: Verify LZ4 frame content checksum on the read path#22162
Open
radmirnovii wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20528: Verify LZ4 frame content checksum on the read path#22162radmirnovii wants to merge 1 commit intoapache:trunkfrom
radmirnovii wants to merge 1 commit intoapache:trunkfrom
Conversation
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lz4BlockInputStream consumed the 4-byte XXH32 content-checksum trailer when the FLG bit was set but never compared it against the decoded payload, so non-Kafka producers' frames passed through unverified. (Kafka's own writer hardcodes the bit to 0, so Kafka-to-Kafka frames are unaffected.)
Fix: hash decoded blocks via Checksums.update on a
StreamingXXHash32 and verify at the endmark