KAFKA-20413: Make Streams suppress headers-aware#22165
Open
aliehsaeedii wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20413: Make Streams suppress headers-aware#22165aliehsaeedii wants to merge 1 commit intoapache:trunkfrom
aliehsaeedii wants to merge 1 commit intoapache:trunkfrom
Conversation
aliehsaeedii
changed the title
UladzislauBlok
approved these changes
Apr 29, 2026
| final MockInternalProcessorContext<?, ?> context = makeContext(); | ||
| buffer.init(context, buffer); | ||
|
|
||
| final RecordHeaders headers = new RecordHeaders(new Header[]{new RecordHeader("h1", "v1".getBytes(UTF_8))}); |
Contributor
There was a problem hiding this comment.
minor: we don't need to specify utf8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the suppress-buffer part of KAFKA-20413:
InMemoryTimeOrderedKeyValueChangeBuffernow uses the buffered record's own headers in serde calls and on eviction, andpriorValueForBufferedreturns the real timestamp + headers instead ofRecordQueue.UNKNOWN/ emptyRecordHeaders.Testing:
Added
shouldPropagateHeadersThroughEviction,shouldReturnBufferedHeadersFromPriorValue,shouldUseRecordHeadersNotProcessorContextHeadersOnPut.