Skip to content

MINOR: Add tests for RaftVoterEndpoint#22195

Merged
chia7712 merged 2 commits intoapache:trunkfrom
kuoche1712003:test-raft-voter-endpoint
May 3, 2026
Merged

MINOR: Add tests for RaftVoterEndpoint#22195
chia7712 merged 2 commits intoapache:trunkfrom
kuoche1712003:test-raft-voter-endpoint

Conversation

@kuoche1712003
Copy link
Copy Markdown
Contributor

@kuoche1712003 kuoche1712003 commented May 2, 2026

Add tests for RaftVoterEndpoint

Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com

@github-actions github-actions Bot added triage PRs from the community clients small Small PRs labels May 2, 2026
Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented May 2, 2026

@kuoche1712003 would you mind testing both equals and hashCode?

@github-actions github-actions Bot removed the small Small PRs label May 3, 2026
@kuoche1712003 kuoche1712003 force-pushed the test-raft-voter-endpoint branch from 95e11fc to 18b7ce9 Compare May 3, 2026 02:27
@kuoche1712003
Copy link
Copy Markdown
Contributor Author

@chia7712 Thanks for the review! I've added tests for both equals and hashCode.

@kuoche1712003 kuoche1712003 force-pushed the test-raft-voter-endpoint branch from 18b7ce9 to f1cce39 Compare May 3, 2026 02:30
Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@github-actions github-actions Bot removed the triage PRs from the community label May 3, 2026
@chia7712 chia7712 merged commit b563238 into apache:trunk May 3, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants