KAFKA-20380; backwards compatible advertised.listeners when it is not defined#22218
Open
kevin-wu24 wants to merge 1 commit intoapache:4.0from
Open
KAFKA-20380; backwards compatible advertised.listeners when it is not defined#22218kevin-wu24 wants to merge 1 commit intoapache:4.0from
kevin-wu24 wants to merge 1 commit intoapache:4.0from
Conversation
… defined (apache#21918) Kafka can incorrectly resolve the advertised listener for controllers if it is not specified. For controller configurations that specify the controller.quorum.voters but not the advertised.listener, Kafka can deduce the advertise listener for the default listener. In this cases, Kafka will automatically set the advertised listener for the default listener to the endpoint specified in controller.quorum.voters. Reviewers: José Armando García Sancio <jsancio@apache.org> Co-authored-by: José Armando García Sancio <jsancio@apache.org> Conflicts: core/src/main/scala/kafka/server/KafkaConfig.scala core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala Conflicts related to kafka.cluster.EndPoint being moved to org.apache.kafka.common.Endpoint
kevin-wu24
force-pushed
the
KAFKA-20380-cherry-40
branch
from
a9a6995 to
ebe6392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka can incorrectly resolve the advertised listener for controllers if it is not specified. For controller configurations that specify the controller.quorum.voters but not the advertised.listener, Kafka can deduce the advertise listener for the default listener. In this cases, Kafka will automatically set the advertised listener for the default listener to the endpoint specified in controller.quorum.voters.
Reviewers: José Armando García Sancio jsancio@apache.org
Co-authored-by: José Armando García Sancio jsancio@apache.org
Conflicts:
core/src/main/scala/kafka/server/KafkaConfig.scala
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
Conflicts related to kafka.cluster.EndPoint being moved to org.apache.kafka.common.Endpoint