MINOR: Move testCallInFlightTimeouts to Java and remove internal factory hack#22220
Open
JiayaoS wants to merge 1 commit intoapache:trunkfrom
Open
MINOR: Move testCallInFlightTimeouts to Java and remove internal factory hack#22220JiayaoS wants to merge 1 commit intoapache:trunkfrom
JiayaoS wants to merge 1 commit intoapache:trunkfrom
Conversation
JiayaoS
changed the title
JiayaoS
force-pushed
the
feature/AdminClientTimeoutIntegrationTest
branch
from
c10fd1a to
865e133
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
testCallInFlightTimeoutsfrom the Scala core module to a newJava
AdminClientTimeoutIntegrationTestinclients-integration-tests.By placing the test in the
org.apache.kafka.clients.adminpackage, itcan directly access
KafkaAdminClient.createInternal(). This allows usto:
KafkaAdminClientInternalFactorybackdoor, restoringproper encapsulation.
FailureInjectingTimeoutProcessorFactoryinto the test class,reducing test fixture clutter.