MINOR: fix DynamicBrokerReconfigurationTest#22226
Merged
chia7712 merged 2 commits intoapache:trunkfrom May 6, 2026
Merged
Conversation
The test is subject to a race-condition. This PR change async to sync call to fix it.
github-actions
Bot
added
core
Member
Author
|
Call for review @mingyen066 @chia7712 (follow up to #22110) |
chia7712
approved these changes
May 6, 2026
|
|
||
| private def alterConfigs(servers: Seq[KafkaBroker], adminClient: Admin, props: Properties, | ||
| perBrokerConfig: Boolean): Unit = { | ||
| alterConfigsAsync(servers, adminClient, props, perBrokerConfig).all.get() |
Member
There was a problem hiding this comment.
nit: Should we wait for all servers to sync to ensure those race conditions go away?
props.asScala.foreach { case (k, v) =>
waitForConfig(k, v)
}
Member
BTW, PR #22110 just moved some files, so I'm curious how that introduced these race conditions. Would you mind sharing some of your magic with me? |
Member
Author
|
It's Confluent internal stuff, but this test started to failing for us, when we incorporating #22110. We could also fix internally only, but as it's race condition in AK code base, better to fix upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is subject to a race-condition. This PR change async to sync
call to fix it.
Reviewers: Chia-Ping Tsai chia7712@gmail.com