MINOR: Clean up OffsetCommit request/response validation tests in KafkaApisTest#22250
Merged
Merged
Conversation
…kaApisTest - Consolidate `testHandleOffsetCommitRequestTopicsAndPartitionsValidation` and `testHandleOffsetCommitRequestTopicsAndPartitionsValidationWithTopicIds` into a single `@ParameterizedTest @ApiKeyVersionsSource(apiKey = ApiKeys.OFFSET_COMMIT)` method that covers every API version, mirroring the shape of `testHandleTxnOffsetCommitRequestTopicsAndPartitionsValidation`. - Drop the unnecessary version gating on `topicId`/`name` in the source request data of `testHandleOffsetCommitRequest` and `testHandleOffsetCommitRequestFutureFailed`. Both fields can be set unconditionally; the wire schema filters at serialization time and the builder accepts requests that have both fields populated.
github-actions
Bot
added
core
squah-confluent
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testHandleOffsetCommitRequestTopicsAndPartitionsValidationand
testHandleOffsetCommitRequestTopicsAndPartitionsValidationWithTopicIdsinto a single
@ParameterizedTest @ApiKeyVersionsSource(apiKey = ApiKeys.OFFSET_COMMIT)method that covers every API version, mirroring the shape of
testHandleTxnOffsetCommitRequestTopicsAndPartitionsValidation.topicId/namein thesource request data of
testHandleOffsetCommitRequestandtestHandleOffsetCommitRequestFutureFailed. Both fields can be setunconditionally; the wire schema filters at serialization time and
the builder accepts requests that have both fields populated.
Reviewers: Sean Quah squah@confluent.io