MINOR: Fix race in StreamsGroupHeartbeatRequestTest testDynamicGroupConfig#22277
Merged
squah-confluent merged 1 commit intoMay 14, 2026
Conversation
…onfig In testDynamicGroupConfig, we dynamically configure a group's streams.num.standby.replicas, followed by streams.task.offset.interval.ms. We then wait for the next assignment and check that it has the expected number of standby replicas and expected task offset interval. However, this only guarantees that the new streams.num.standby.replicas config has propagated to the group coordinator and not necessarily the new task offset interval. Add a loop to heartbeat until we observe the expected task offset interval or a timeout elapses.
github-actions
Bot
added
core
mjsax
approved these changes
May 14, 2026
squah-confluent
deleted the
squah-fix-streamsgroupheartbeatrequesttest-flake
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In testDynamicGroupConfig, we dynamically configure a group's
streams.num.standby.replicas, followed by
streams.task.offset.interval.ms. We then wait for the next assignment
and check that it has the expected number of standby replicas and
expected task offset interval. However, this only guarantees that the
new streams.num.standby.replicas config has propagated to the group
coordinator and not necessarily the new task offset interval.
Add a loop to heartbeat until we observe the expected task offset
interval or a timeout elapses.
Reviewers: Lucas Brutschy lbrutschy@confluent.io, Matthias J. Sax
matthias@confluent.io