KAFKA-20545: Fix flaky MirrorConnectorsIntegrationSSLTest testConnectorMetrics* tests#22291
Merged
Conversation
github-actions
Bot
added
triage
| } | ||
|
|
||
| private void testConnectorMetrics(String format, Supplier<Boolean> assertions) throws InterruptedException, ExecutionException { | ||
| CollectAllMetricsReporter.METRICS.clear(); |
Contributor
There was a problem hiding this comment.
I think this is redundant with afterEach ?
Contributor
Author
There was a problem hiding this comment.
You're right, it is redundant. @AfterEach clears METRICS after every test, so by the time testConnectorMetrics runs the map is already empty. Removed the clear from testConnectorMetrics and kept only the @AfterEach one.
nileshkumar3
commented
May 17, 2026
Contributor
Author
nileshkumar3
left a comment
nileshkumar3
left a comment
There was a problem hiding this comment.
@muralibasani Thanks for reviewing the PR. I fixed the review comment, Please look when you get a chance.
Contributor
Author
|
@mimaison could you please review when get a chance. |
Contributor
Author
Thanks for the review. |
Contributor
Author
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the static
CollectAllMetricsReporter.METRICSmap in@AfterEachand at the start of
testConnectorMetricsso metric counts are notpolluted by prior tests in the same JVM.
Fixes flaky failures where
assertMetricsnever reached the expected156 source / 4 checkpoint metrics and
waitForConditiontimed out with"Unable to find the MirrorMaker metrics".
Reviewers: Mickael Maison mickael.maison@gmail.com, Murali Basani
muralidhar.basani@aiven.io