KAFKA-17689 Migrate TieredStorageTestHarness to new test infra (AlterLogDirTest) #22306
Merged
Conversation
github-actions
Bot
added
triage
chia7712
reviewed
May 18, 2026
| public int brokerCount() { | ||
| return 2; | ||
| private static final String TEST_CLASS_NAME = "alterlogdirtest"; | ||
| private static final int BROKER_COUNT = 2; |
Member
There was a problem hiding this comment.
Would you please set it to 3 in order to create the offset topic? Alternatively, you could set the replication factor to 1 instead.
Collaborator
Author
There was a problem hiding this comment.
Sure, I have updated BROKER_COUNT to 3.
| .setTypes(Set.of(Type.KRAFT)) | ||
| .setBrokers(BROKER_COUNT) | ||
| .setDisksPerBroker(2) | ||
| .setServerProperties(createServerPropsForRemoteStorage(TEST_CLASS_NAME, BROKER_COUNT, 5)) |
Member
There was a problem hiding this comment.
How about AlterLogDirTest.class.getSimpleName().toLowerCase(Locale.ROOT)? This follows pattern in TieredStorageTestHarness.
Collaborator
Author
There was a problem hiding this comment.
Thanks, addressed it
FrankYang0529
approved these changes
May 20, 2026
TaiJuWu
approved these changes
May 20, 2026
chia7712
approved these changes
May 21, 2026
JiayaoS
pushed a commit
to JiayaoS/kafka
that referenced
this pull request
May 21, 2026
…LogDirTest) (apache#22306) Migrate `AlterLogDirTest` to the new test infrastructure Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, PoAn Yang <payang@apache.org>, TaiJuWu <tjwu1217@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
AlterLogDirTestto the new test infrastructureReviewers: Chia-Ping Tsai chia7712@gmail.com, PoAn Yang
payang@apache.org, TaiJuWu tjwu1217@gmail.com