Skip to content

KAFKA-20404: Replace bulk TaskManager atomicity exclude with a field-level suppression #22340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phixsura wants to merge 1 commit into
base: trunk
Choose a base branch
from
+7 −1
Open

KAFKA-20404: Replace bulk TaskManager atomicity exclude with a field-level suppression #22340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gradle/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,6 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read
<Class name="org.apache.kafka.streams.processor.internals.InternalTopologyBuilder"/>
<Class name="org.apache.kafka.streams.processor.internals.StreamsPartitionAssignor"/>
<Class name="org.apache.kafka.streams.processor.internals.StreamsProducer"/>
<Class name="org.apache.kafka.streams.processor.internals.TaskManager"/>
<Class name="org.apache.kafka.streams.state.internals.AbstractRocksDBSegmentedBytesStore"/>
<Class name="org.apache.kafka.streams.state.internals.InMemoryTimeOrderedKeyValueChangeBuffer"/>
<Class name="org.apache.kafka.streams.state.internals.RocksDBStore"/>
Expand Down Expand Up @@ -638,6 +637,13 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read
<Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
</Match>

<Match>
<!-- KAFKA-20404: rebalanceInProgress is written from the ConsumerRebalanceListener callbacks (handleRebalanceStart / handleRebalanceComplete) and read from StreamThread.runLoop and TaskManager's commit paths; all of these run on the StreamThread, so a stale cross-thread write cannot occur. -->
<Class name="org.apache.kafka.streams.processor.internals.TaskManager"/>
<Field name="rebalanceInProgress"/>
<Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
</Match>

<Match>
<!-- New warning type added when we upgraded from spotbugs 4.8.6 to 4.9.4.
These are possibly real bugs, and have not been evaluated, they were just bulk excluded to unblock upgrading Spotbugs.
Expand Down