Skip to content

KAFKA-17689 Migrate TieredStorageTestHarness to new test infra (ListOffsetsTest)#22369

Merged
chia7712 merged 2 commits into
apache:trunkfrom
unknowntpo:KAFKA-17689-list-offsets-test
May 26, 2026
Merged

KAFKA-17689 Migrate TieredStorageTestHarness to new test infra (ListOffsetsTest)#22369
chia7712 merged 2 commits into
apache:trunkfrom
unknowntpo:KAFKA-17689-list-offsets-test

Conversation

@unknowntpo
Copy link
Copy Markdown
Contributor

@unknowntpo unknowntpo commented May 26, 2026

Migrate ListOffsetsTest to the new test infrastructure

Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com

@github-actions github-actions Bot added triage PRs from the community tests Test fixes (including flaky tests) storage Pull requests that target the storage module small Small PRs labels May 26, 2026
Signed-off-by: Eric Chang <e850506@gmail.com>
@unknowntpo unknowntpo force-pushed the KAFKA-17689-list-offsets-test branch from 9345362 to d856558 Compare May 26, 2026 02:03
@unknowntpo unknowntpo marked this pull request as ready for review May 26, 2026 02:03
Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.


public final class ListOffsetsTest {

private static final int BROKER_COUNT = 2;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please set it to 3 in order to create the offset topic? Alternatively, you could set the replication factor to 1 instead.

Suggested change
private static final int BROKER_COUNT = 2;
private static final int BROKER_COUNT = 3;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. thanks for reminding me.

@github-actions github-actions Bot removed the triage PRs from the community label May 26, 2026
Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@chia7712 chia7712 merged commit a562042 into apache:trunk May 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved small Small PRs storage Pull requests that target the storage module tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants