MINOR: update KTable JavaDoc by mjsax · Pull Request #2438 · apache/kafka

mjsax · 2017-01-26T08:24:58Z

No description provided.

mjsax · 2017-01-26T08:25:13Z

asfbot · 2017-01-26T09:05:51Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1224/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-01-26T09:11:43Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1226/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-26T09:18:08Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1224/
Test PASSed (JDK 7 and Scala 2.10).

dguy

Some typos/grammar changes

dguy · 2017-01-26T09:30:42Z

We should actually remove the reference to KTable as we don't currently support it

dguy · 2017-01-26T09:33:12Z

remove "or multiple"
Unless there is something i'm missing a KTable is created from exactly one topic unless it is the result of an aggregation

dguy · 2017-01-26T09:36:01Z

Print the updated...

Was intended as is -- records are updates, so its an "update record" (or update-record). "updated" makes sense, too, though. Not sure what the better wording is...

I see what you mean. I just think "updated records" sounds more natural. But i'm not overly concerned

dguy · 2017-01-26T09:36:15Z

dguy · 2017-01-26T09:36:31Z

dguy · 2017-01-26T09:43:40Z

dguy · 2017-01-26T09:44:38Z

if -> of ?
also add a , before and

Why a comma?
To my knowledge, for two things that are listed there is no comma: "A and B"
Only for three or more, there are command: "A, B, C, and D"

Correct my if I am wrong.

dguy · 2017-01-26T09:45:21Z

dguy · 2017-01-26T09:46:03Z

dguy · 2017-01-26T09:46:31Z

dguy · 2017-01-26T21:51:05Z

Fair enough

…

On Thu, 26 Jan 2017 at 21:40, Matthias J. Sax ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In streams/src/main/java/org/apache/kafka/streams/kstream/KTable.java <#2438>: > - * - * @param selector select the grouping key and value to be aggregated - * @param keySerde key serdes for materializing this stream, - * if not specified the default serdes defined in the configs will be used - * @param valueSerde value serdes for materializing this stream, - * if not specified the default serdes defined in the configs will be used - * @param <K1> the key type of the ***@***.*** KGroupedTable} - * @param <V1> the value type of the ***@***.*** KGroupedTable} - * - * @return a ***@***.*** KGroupedTable} that contains the re-partitioned records of this ***@***.*** KTable} + * Join records of this ***@***.*** KTable} with another ***@***.*** KTable}'s records using non-windowed inner equi join. + * The join is a primary key join with join attribute ***@***.*** thisKTable.key == otherKTable.key}. + * The result is an ever updating ***@***.*** KTable} that represents the <em>current</em> (i.e., processing time) result + * of the join. + * <p> + * The join is computed by (1) updating the internal state if one ***@***.*** KTable} and (2) performing a lookup for a Why? To my knowledge, for two things that are listed there is no comma: "A and B" Only for three or more, there are command: "A, B, C, and D" Correct my if I am wrong. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2438>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADWLXXVYJ3srb9ok59OtUXsf3l_3pEDks5rWRKwgaJpZM4LuZIE> .

mjsax · 2017-01-27T01:53:44Z

Addressed @dguy comments. (Not the part about "update records" -- but we can discuss if we want to reword).

Also added KGroupedTable and GlobalKTable.

Some minor refactoring in KStream and KGroupedStream (always discovering small issues along the way...)

Call for review @eno @guozhangwang

asfbot · 2017-01-27T02:40:24Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1282/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-27T02:40:37Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1280/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-27T03:14:01Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1280/
Test PASSed (JDK 7 and Scala 2.10).

mjsax · 2017-01-27T07:47:43Z

Rebased to resolve conflict.

asfbot · 2017-01-27T09:45:37Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1284/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-27T09:58:05Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1286/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-27T10:51:30Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1284/
Test PASSed (JDK 7 and Scala 2.10).

asfbot · 2017-01-27T12:19:13Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1287/
Test FAILed (JDK 7 and Scala 2.10).

asfbot · 2017-01-27T12:59:11Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1289/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-27T13:01:12Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1287/
Test PASSed (JDK 8 and Scala 2.12).

Author: Matthias J. Sax <matthias@confluent.io> Reviewers: Damian Guy <damian.guy@gmail.com> Closes #2438 from mjsax/ktableJavaDocs (cherry picked from commit 1bd11b2) Signed-off-by: Guozhang Wang <wangguoz@gmail.com>

guozhangwang · 2017-01-27T16:41:19Z

Merged to trunk and 0.10.2.

Author: Matthias J. Sax <matthias@confluent.io> Reviewers: Damian Guy <damian.guy@gmail.com> Closes apache#2438 from mjsax/ktableJavaDocs

dguy requested changes Jan 26, 2017

View reviewed changes

mjsax force-pushed the ktableJavaDocs branch from 81cfacc to f10c613 Compare January 27, 2017 01:51

MINOR: update KTable, KGroupedTable, and GlobalKTable JavaDocs

402e910

mjsax force-pushed the ktableJavaDocs branch from f10c613 to 402e910 Compare January 27, 2017 07:47

rebased

fcb6fff

dguy approved these changes Jan 27, 2017

View reviewed changes

added query hint to GlobalKTable

8807f09

asfgit closed this in 1bd11b2 Jan 27, 2017

mjsax deleted the ktableJavaDocs branch January 28, 2017 01:24

soenkeliebau pushed a commit to soenkeliebau/kafka that referenced this pull request Feb 7, 2017

MINOR: Update KTable JavaDoc

3282951

Author: Matthias J. Sax <matthias@confluent.io> Reviewers: Damian Guy <damian.guy@gmail.com> Closes apache#2438 from mjsax/ktableJavaDocs

Conversation

mjsax commented Jan 26, 2017

Uh oh!

mjsax commented Jan 26, 2017

Uh oh!

asfbot commented Jan 26, 2017

Uh oh!

asfbot commented Jan 26, 2017

Uh oh!

asfbot commented Jan 26, 2017

Uh oh!

dguy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjsax Jan 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dguy commented Jan 26, 2017 via email

Uh oh!

mjsax commented Jan 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

mjsax commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

asfbot commented Jan 27, 2017

Uh oh!

guozhangwang commented Jan 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mjsax Jan 26, 2017 •

edited

Loading

mjsax commented Jan 27, 2017 •

edited

Loading