HOTFIX: Fix unsafe dependence on class name in VerifiableClientJava#2736
HOTFIX: Fix unsafe dependence on class name in VerifiableClientJava#2736hachikuji wants to merge 2 commits into
Conversation
ewencp
left a comment
ewencp
left a comment
There was a problem hiding this comment.
Wow, totally did not catch this during the review of the changes for pluggable clients.
One very minor cleanup issue, then LGTM
|
|
||
|
|
||
|
|
||
| """ |
There was a problem hiding this comment.
docstrings go below the class (unlike every other language). same with other changes in this patch
|
FWIW, here's the build off this branch which is looking good so far: https://jenkins.confluent.io/view/All/job/system-test-confluent-platform-branch-builder/195/console |
|
LGTM, no point waiting for jenkins since this is all system test code. Will merge to trunk. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
3 participants
No description provided.