Skip to content

MINOR: update stream docs for kip-134#3179

Closed
dguy wants to merge 2 commits into
apache:trunkfrom
dguy:kip134-doc
Closed

MINOR: update stream docs for kip-134#3179
dguy wants to merge 2 commits into
apache:trunkfrom
dguy:kip134-doc

Conversation

@dguy
Copy link
Copy Markdown
Contributor

@dguy dguy commented May 31, 2017

Add a section in the streams docs about the broker config introduced in KIP-134

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented May 31, 2017

Comment thread docs/streams.html Outdated
<p>
Introduced in 0.11.0 is a new broker config that is particularly relevant to Kafka Streams applications, <code>group.initial.rebalance.delay.ms</code>.
This config specifies the time, in milliseconds, that the <code>GroupCoordinator</code> will delay the initial consumer rebalance.
The rebalance will be further delayed by the value of <code>group.initial.rebalance.delay.ms<</code> as each new member joins the consumer group, up to a maximum of the value set by <code>max.poll.interval.ms</code>.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo extra '<'

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented May 31, 2017

just one small typo, otherwise LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented May 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/4644/
Test FAILed (JDK 7 and Scala 2.11).

Comment thread docs/streams.html Outdated
</p>


<h4><a id="streams_execute" href="streams_execute">Executing Your Kafka Streams Application</a></h4>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should read:

href="#streams_execute"

Note the #.

Comment thread docs/streams.html Outdated
<script><!--#include virtual="js/templateData.js" --></script>

<script id="streams-template" type="text/x-handlebars-template">
<!--<script id="streams-template" type="text/x-handlebars-template">-->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? This looks odd.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

Comment thread docs/streams.html Outdated
</ul>

</script>
<!--</script>-->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? This looks odd. Why is the <script> disabled now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - commented it out so i could test in browser. doh!

@asfbot
Copy link
Copy Markdown

asfbot commented May 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/4629/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented May 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/4639/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented May 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/4654/
Test PASSed (JDK 7 and Scala 2.11).

@dguy
Copy link
Copy Markdown
Contributor Author

dguy commented Jun 6, 2017

@guozhangwang

asfgit pushed a commit that referenced this pull request Jun 6, 2017
Add a section in the streams docs about the broker config introduced in KIP-134

Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Michael G. Noll, Bill Bejeck, Guozhang Wang

Closes #3179 from dguy/kip134-doc

(cherry picked from commit ad8e7cf)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM. Merged to trunk and 0.11.0.

@asfgit asfgit closed this in ad8e7cf Jun 6, 2017
@dguy dguy deleted the kip134-doc branch August 16, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants