MINOR: NetworkClient#disconnect should not erase connection info#3309
MINOR: NetworkClient#disconnect should not erase connection info#3309cmccabe wants to merge 3 commits intoapache:trunkfrom
Conversation
NetworkClient#disconnect should not erase the connection information. This will allow exponential backoff to occur.
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Would it be possible to add a simple unit test?
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Good idea. I added a unit test. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM. Can you please fix the unused import checkstyle error?
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
NetworkClient#disconnect should not erase the connection information. This will allow exponential backoff to occur. Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #3309 from cmccabe/disc (cherry picked from commit d099c74) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
3 participants
NetworkClient#disconnect should not erase the connection information. This will allow exponential
backoff to occur.