KAFKA-2626: Handle null keys and value validation properly in OffsetStorageWriter.#345
Closed
ewencp wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-2626: Handle null keys and value validation properly in OffsetStorageWriter.#345ewencp wants to merge 1 commit intoapache:trunkfrom
ewencp wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
|
2 lines of code, 56 lines of tests :) LGTM. |
Contributor
Author
|
@gwenshap That's how I roll. |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
Jul 8, 2020
Add describe quorum API. 1. Add data templates 2. Consolidate fetch time and offset updates 3. Separate replica State from voter state for observers 4. Bookkeep seen observers 5. Attach topic partition to the Replicated log Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
to hachikuji/kafka
that referenced
this pull request
Aug 5, 2020
Add describe quorum API. 1. Add data templates 2. Consolidate fetch time and offset updates 3. Separate replica State from voter state for observers 4. Bookkeep seen observers 5. Attach topic partition to the Replicated log Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
to hachikuji/kafka
that referenced
this pull request
Aug 13, 2020
Add describe quorum API. 1. Add data templates 2. Consolidate fetch time and offset updates 3. Separate replica State from voter state for observers 4. Bookkeep seen observers 5. Attach topic partition to the Replicated log Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…pache#345) TICKET = LIKAFKA-44962 LI_DESCRIPTION = 1. Add the SumOfTopicNameLength metric to track the scalability risk of kafka clusters. When the metric hits the 1M limit, a vanilla zk client won't be able to read all of the topic names that are placed under the same /brokers/topics znode. We are currently working on using the zk pagination feature to get past the 1M limit. Nonetheless, it's useful to monitor this value. 2. Add minor fixes of the code base to avoid compiler warnings EXIT_CRITERIA = N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.