MINOR: InFlightRequests#isEmpty(node) method corrected.

[kamalcph]

• In clearAll method, get operation is removed.
• variable name requestTimeout changed to requestTimeoutMs for clarity

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5830/
Test PASSed (JDK 8 and Scala 2.12).

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5844/
Test PASSed (JDK 7 and Scala 2.11).

[rajinisivaram]

Thanks for the PR. LGTM

[ijuma]

We should include a test to verify this change.

[rajinisivaram]

@ijuma Unit tests of NetworkClient do check that InflightRequests works correctly. Obviously, it used to work before because two methods used matching wrong values, but I didn't think there was much value in unit tests for InflightRequests just for this change.

[ijuma]

@rajinisivaram Ideally we'd have unit tests for classes like InflightRequests. They make it less likely that things like this are missed. In this case, it was OK, but we could have had a situation where we started using the incorrect method in some edge case that wasn't exercised in the tests and it would be bad.

[rajinisivaram]

@ijuma Ideally, we would have unit tests for all classes :-)
@kamal15 Would you like to submit unit test for InflightRequests?

[kamalcph]

@rajinisivaram @ijuma

Thanks for reviewing the PR. I ll submit the unit test for InflightRequests shortly.