Skip to content

HOTFIX: call consumer.poll() even when no task is assigned #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ymatsuda wants to merge 1 commit into from
Closed

HOTFIX: call consumer.poll() even when no task is assigned #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,22 +265,29 @@ private void runLoop() {
sensors.pollTimeSensor.record(endPoll - startPoll);
}

// try to process one record from each task
totalNumBuffered = 0;
requiresPoll = false;

for (StreamTask task : tasks.values()) {
long startProcess = time.milliseconds();
if (!tasks.isEmpty()) {
// try to process one record from each task
requiresPoll = false;

totalNumBuffered += task.process();
requiresPoll = requiresPoll || task.requiresPoll();
for (StreamTask task : tasks.values()) {
long startProcess = time.milliseconds();

sensors.processTimeSensor.record(time.milliseconds() - startProcess);
totalNumBuffered += task.process();
requiresPoll = requiresPoll || task.requiresPoll();

sensors.processTimeSensor.record(time.milliseconds() - startProcess);
}

maybePunctuate();
maybeCommit();
} else {
// even when no task is assigned, we must poll to get a task.
requiresPoll = true;
}

maybePunctuate();
maybeClean();
maybeCommit();
}
} catch (Exception e) {
throw new KafkaException(e);
Expand Down