MINOR: Introduce producer.config property to ConsoleProducer#544
Conversation
This makes it easier to pass security properties in the same way to `ConsoleConsumer` and `ConsoleProducer`.
ijuma
force-pushed
the
producer-config-in-console-producer
branch
from
fd53d95 to
ac5194b
Compare
There was a problem hiding this comment.
Just curious, do we need both "producer-property" and "producer.config" for passing the property values? And if yes let's make their naming style consistent.
There was a problem hiding this comment.
I'd remove producer-property, but that would break existing users right? Regarding the naming, I don't have a strong opinion, but we have producer.config in VerifiableProducer, MirrorMaker, ProducerPerformance and KafkaMigrationTool. And consumer.config in ConsoleConsumer, ConsumerPerformance, MirrorMaker, KafkaMigrationTool.
There was a problem hiding this comment.
I think the inconsistency with other options is better than inconsistency with every other tool. I suggest we look at making an improvement across all tools after 0.9.0.0.
There was a problem hiding this comment.
Can we use producer-config instead of producer.config to be inline with format of other options?
There was a problem hiding this comment.
Could we add in the description that producer-property takes precedence over producer.config ?
There was a problem hiding this comment.
@junrao Pushed a commit with your suggestion. @SinghAsDev, I explained above why I used producer.config (it's what every other tool uses).
|
./gradlew test passed locally |
As suggested by Jun.
|
Thanks for the patch. LGTM |
This makes it easier to pass security properties in the same way to `ConsoleConsumer` and `ConsoleProducer`. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jun Rao <junrao@gmail.com> Closes #544 from ijuma/producer-config-in-console-producer (cherry picked from commit 06d2c78) Signed-off-by: Jun Rao <junrao@gmail.com>
This makes it easier to pass security properties in the same way to `ConsoleConsumer` and `ConsoleProducer`. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jun Rao <junrao@gmail.com> Closes #544 from ijuma/producer-config-in-console-producer
Add a new limiting configuration for cache sizing based on bytes instead of entries. Historically, previous caching library only supported sizing based on entries. With Caffeine, sizing can now be defined by both entries and max bytes using weigher. When bytes limit is configured, weight-based eviction takes precedence over count-based eviction. Caffeine does not support both simultaneously. (cherry picked from commit cbfdff5)
Add a new limiting configuration for cache sizing based on bytes instead of entries. Historically, previous caching library only supported sizing based on entries. With Caffeine, sizing can now be defined by both entries and max bytes using weigher. When bytes limit is configured, weight-based eviction takes precedence over count-based eviction. Caffeine does not support both simultaneously.
4 participants
This makes it easier to pass security properties in the same way
to
ConsoleConsumerandConsoleProducer.