KAFKA-7386: streams-scala should not cache serdes #5622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
bbejeck
approved these changes
Sep 7, 2018
Contributor
|
Mutablility... |
Contributor
Author
|
@joan38 , Yeah, sort of... What's actually going on is more like dependency injection. The class is being configured after creation and then cached. But, yes, this can be (and has been) a source of bugs. |
Contributor
Author
|
Ok, @guozhangwang , I think this is good to go. |
Contributor
|
LGTM! |
guozhangwang
pushed a commit
that referenced
this pull request
Sep 11, 2018
Currently, scala.Serdes.String, for example, invokes Serdes.String() once and caches the result. However, the implementation of the String serde has a non-empty configure method that is variant in whether it's used as a key or value serde. So we won't get correct execution if we create one serde and use it for both keys and values. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Contributor
|
Cherry-picked to 2.0 as well. |
Contributor
Author
|
Thanks @guozhangwang |
Member
|
This is definitely mutability and makes the implicit usage quite suspect. Unfortunate. :( |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Currently, scala.Serdes.String, for example, invokes Serdes.String() once and caches the result. However, the implementation of the String serde has a non-empty configure method that is variant in whether it's used as a key or value serde. So we won't get correct execution if we create one serde and use it for both keys and values. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
scala.Serdes.String, for example, invokes Serdes.String() once and caches the result.However, the implementation of the String serde has a non-empty configure method that is variant in whether it's used as a key or value serde. So we won't get correct execution if we create one serde and use it for both keys and values.
Committer Checklist (excluded from commit message)