MINOR: Need to have same wait as verify timeout broker upgrade downgrade#6127
Merged
guozhangwang merged 4 commits intoapache:trunkfrom Jan 11, 2019
Conversation
…st, increase timeout to match timeout in SmokeTestDriver verfication step.
Member
Author
|
@guozhangwang, @mjsax, and @vvcephei for reviews |
| metadata_3_or_higher_versions = [str(LATEST_2_0), str(LATEST_2_1), str(DEV_VERSION)] | ||
|
|
||
| """ | ||
| After each any release this test needs to get updated, but this requires several steps |
Contributor
There was a problem hiding this comment.
After each release ... one should first check that the released version has been uploaded to https://s3-us-west-2.amazonaws.com/kafka-packages/ which is the url used by system test to download jars; anyone can verify that by calling curl https://s3-us-west-2.amazonaws.com/kafka-packages/kafka_$scala_version-$version.tgz to download the jar. If it is not uploaded yet, ping the dev@kafka mailing list to request it being uploaded.
nit: each any -> each.
Member
Author
|
updated this |
vvcephei
reviewed
Jan 11, 2019
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the documentation as well.
Member
Author
|
Thanks @guozhangwang and @vvcephei |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ade (apache#6127) When I originally refactored the streams_upgrade_test#upgrade_downgrade_brokers test I removed the wait call which would wait for up 24 minutes for the SmokeTestDriver class to publish and verify all of its records. Since most of the tests run in two minutes or less I set the monitor_log timeout to three minutes. However, the SmokeTestDriver#verify method allows up to six minutes to consume all records before verifying the monitor_log timeout needs to be greater than 6 minutes. I've set the timeout to 8 minutes. Additionally, the steps needed to update the streams_upgrade_test should be documented as there are several components that need to get updated. So I've documented those steps here on the test as a giant comment. Reviewers: Guozhang Wang <wangguoz@gmail.com>
bbejeck
deleted the
MINOR_need_to_have_same_wait_as_verify_timeout_broker_upgrade_downgrade
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I originally refactored the
streams_upgrade_test#upgrade_downgrade_brokerstest I removed thewaitcall which would wait for up 24 minutes for theSmokeTestDriverclass to publish and verify all of its records.Since most of the tests run in two minutes or less I set the
monitor_logtimeout to three minutes. However, theSmokeTestDriver#verifymethod allows up to six minutes to consume all records before verifying themonitor_logtimeout needs to be greater than 6 minutes. I've set the timeout to 8 minutes.Additionally, the steps needed to update the
streams_upgrade_testshould be documented as there are several components that need to get updated. So I've documented those steps here on the test as a giant comment.I ran a branch builder (just for the broker upgrade tests) http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2019-01-11--001.1547174767--bbejeck--MINOR_need_to_have_same_wait_as_verify_timeout_broker_upgrade_downgrade--4fec6e4/report.html and all tests passed
Committer Checklist (excluded from commit message)