Skip to content

MINOR: change the log level from ERROR to DEBUG when failing to get plugin class loader#7964

Merged
hachikuji merged 1 commit intoapache:trunkfrom
chia7712:fix_change_log_level_to_debug_when_failing_to_find_the_plugin_loader_for_plugin
Jan 21, 2020
Merged

MINOR: change the log level from ERROR to DEBUG when failing to get plugin class loader#7964
hachikuji merged 1 commit intoapache:trunkfrom
chia7712:fix_change_log_level_to_debug_when_failing_to_find_the_plugin_loader_for_plugin

Conversation

@chia7712
Copy link
Copy Markdown
Member

@chia7712 chia7712 commented Jan 15, 2020

The connectors located at classpath are loaded by AppClassLoader so Worker fails to find the PluginClassLoader for them. It should be normal case but the log level is ERROR.

there is similar case in DelegatingClassLoader#loadClass, and the log level is TRACE.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 force-pushed the fix_change_log_level_to_debug_when_failing_to_find_the_plugin_loader_for_plugin branch from 0838820 to e2bb4d4 Compare January 19, 2020 03:58
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice cleanup.

@hachikuji
Copy link
Copy Markdown
Contributor

retest this please

1 similar comment
@hachikuji
Copy link
Copy Markdown
Contributor

retest this please

@hachikuji hachikuji merged commit a14f255 into apache:trunk Jan 21, 2020
ijuma added a commit to confluentinc/kafka that referenced this pull request Jan 23, 2020
* apache-github/trunk:
  KAFKA-9418; Add new sendOffsetsToTransaction API to KafkaProducer (apache#7952)
  KAFKA-7273 Clarification on mutability of headers passed to Converter#fromConnectData() (apache#7489)
  MINOR: Only update a request's local complete time in API handler if unset (apache#7813)
  KAFKA-9143: Log task reconfiguration error only when it happened (apache#7648)
  MINOR: Change the log level from ERROR to DEBUG when failing to get plugin loader for connector (apache#7964)
  KAFKA-9024: Better error message when field specified does not exist (apache#7819)
  KAFKA-7204: Avoid clearing records for paused partitions on poll of MockConsumer (apache#7505)
  KAFKA-9083: Various fixes/improvements for Connect's Values class (apache#7593)
  MINOR: log error message from Connect sink exception (apache#7555)
@kkonstantine kkonstantine changed the title MINOR: change the log level from ERROR to TRACE when failing to get p… MINOR: change the log level from ERROR to DEBUG when failing to get plugin class loader Aug 3, 2020
@chia7712 chia7712 deleted the fix_change_log_level_to_debug_when_failing_to_find_the_plugin_loader_for_plugin branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants